Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run_ci_checks.sh #419

Closed
wants to merge 1 commit into from
Closed

Conversation

ethvs
Copy link
Contributor

@ethvs ethvs commented Dec 8, 2024

optimization

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

Rationale for this change

What changes are included in this PR?

Are these changes tested?

@Dustin-Ray
Copy link
Contributor

Dustin-Ray commented Dec 11, 2024

Hi @ethvs , can you explain your reasoning for this PR? What enhancements does this introduce? Why do we need this right now? Also, please be sure to use clean commits.

I currently understand that the check script will run tests and example code, in addition to the CI checks, which can be very slow on some user machines. I would be ok with a change that removes these steps from the script, but its not clear that youve done that here.

Ill go ahead and mark this PR as draft until the items here are addressed. Please reach out with further questions if you have them, thanks.

@Dustin-Ray Dustin-Ray marked this pull request as draft December 11, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants