Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add time example #293

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add time example #293

wants to merge 4 commits into from

Conversation

JayWhite2357
Copy link
Contributor

@JayWhite2357 JayWhite2357 commented Oct 22, 2024

Rationale for this change

More examples in the repo provide better documentation as well as provide some regression testing on top of other tests.

What changes are included in this PR?

A simple example is added.

Are these changes tested?

Yes

@JayWhite2357 JayWhite2357 changed the title feat: add time example feat: add time example Oct 22, 2024
owned_table([
varchar(
"name",
[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JayWhite2357 I'd like to add first names as well to demonstrate that we can have whitespaces in our data

@Dustin-Ray
Copy link
Contributor

I can approve once the conflict with "Cargo.toml" is resolved

Comment on lines +119 to +120
- name: Run time example
run: cargo run --example time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants