Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vents lock out too easily #33390

Open
K-Dynamic opened this issue Nov 18, 2024 · 12 comments
Open

Vents lock out too easily #33390

K-Dynamic opened this issue Nov 18, 2024 · 12 comments
Labels
A: Engineering Area: Engineering department, including Atmospherics. A: Mapping Area: Maps, or tools used for mapping D3: Low Difficulty: Some codebase knowledge required. Issue: Replicated This issue has been replicated by another user. P3: Standard Priority: Default priority for repository items. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. T: Cleanup Type: Code clean-up, without being a full refactor or feature

Comments

@K-Dynamic
Copy link
Contributor

K-Dynamic commented Nov 18, 2024

Description

A single syndiebomb will usually cause vents all over the station to lock out, even if the pressure doesn't decrease substantially. This causes repressurisation to be almost impossible and require player intervention to manually unlock vents.

Reproduction

Somewhat difficult to reproduce reliably but it seems to occur after 'large' explosions (ranging from meteors to syndiebombs at the edges of the station), which will cause lockouts in a much larger radius. Needs further testing to check air alarms and pressure readings.

@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 18, 2024
@thebadman4662
Copy link

Its partially caused by very high lockout pressure(like 20% loss already can lock most vents) but also by maps lack of airlocks to protect the atmos, little bit of spacing and half of station atmos are gone at times, bonus points if there is no power for some reason and the smart spessmen do not lock maints as usual.

If nearby sets of airlocks were connected to eachother and set to close they could greatly reduce atmos drain while still not slowing crew too much as they go on their daily lives and spacing station via maints.

Then we have firelocks that often are poorly placed, on door or literally adjacent to door so you can't create small pocket to open from without spacing bigger parts of station. 1-3 tiles of space between firelock and airlock/another firelock set would save stations a lot of atmos and lockouts.

@Boaz1111 Boaz1111 added P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. Issue: Replicated This issue has been replicated by another user. A: Mapping Area: Maps, or tools used for mapping A: Engineering Area: Engineering department, including Atmospherics. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 25, 2024
@K-Dynamic
Copy link
Contributor Author

Really vent lockouts should be tied to firelocks and checking if the room is airtight before unblocking

@thebadman4662
Copy link

thebadman4662 commented Nov 25, 2024

Really vent lockouts should be tied to firelocks and checking if the room is airtight before unblocking

As AI, I could not agree more. Perhaps it should even bolt while in fill mode as safety measure and require hacking(safety wire wyci)/emag to bypass it.

@dylanstrategie
Copy link
Contributor

After discovering how this system works myself, I fully agree it is really, REALLY bad for station operation unless you have an insanely cracked Atmospherics Technican running around manually repressurizing everything

The vent lockout should definitely be set MUCH lower so only rooms which are either obviously spaced or next to a breach don't get refilled. It's not normal that a few people quickly forcing a firelock causes the entire hallway to become permanently depressurized

It's also a bit weird that the only way to fix this is to intentionally set the air alarm to Fill or screwdriver the vent repeatedly. You really have to be VERY aware to see the yellow vent or know what it means, and nowhere are you told that screwdrivering the vent allows you to refill the room if you can't access the alarm. It doesn't even tell you what you did when do end up screwdrivering it!

@thebadman4662
Copy link

It's also a bit weird that the only way to fix this is to intentionally set the air alarm to Fill or screwdriver the vent repeatedly. You really have to be VERY aware to see the yellow vent or know what it means, and nowhere are you told that screwdrivering the vent allows you to refill the room if you can't access the alarm. It doesn't even tell you what you did when do end up screwdrivering it!

So, what exactly screwdriving does? Forces fill for X seconds? Till air alarm changes it again?

@dylanstrategie
Copy link
Contributor

It's also a bit weird that the only way to fix this is to intentionally set the air alarm to Fill or screwdriver the vent repeatedly. You really have to be VERY aware to see the yellow vent or know what it means, and nowhere are you told that screwdrivering the vent allows you to refill the room if you can't access the alarm. It doesn't even tell you what you did when do end up screwdrivering it!

So, what exactly screwdriving does? Forces fill for X seconds? Till air alarm changes it again?

I was literally just told this by a developer, and apparently it disables the lockout for like 10 seconds maximum. But it allows someone without air alarm access to manually refill their room

@slarticodefast
Copy link
Member

A single syndiebomb will usually cause vents all over the station to lock out, even if the pressure doesn't decrease substantially

Our atmos simulation is kinda broken at the moment. We do have instant spacing using a floodfill algorithm, but it is supposed to stop at firelocks and activate them in between atmos ticks. This does not happen at the moment, causing the whole station to be depressurized and the firelocks trigger only when it is already too late. On top of that a few bandaid changes had been made to make spacing slower, which however causes the lockouts not to trigger correctly.

@Ilya246
Copy link
Contributor

Ilya246 commented Nov 26, 2024

it's intentionally set high, without this the vent just never becomes space and keeps voiding air even if there's a breach nearby
i am a first-order source on this as i have tested it

@deltanedas
Copy link
Contributor

theres an ancient pr to make lockout smarter

@ScarKy0 ScarKy0 added T: Cleanup Type: Code clean-up, without being a full refactor or feature and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 27, 2024
@K-Dynamic
Copy link
Contributor Author

Okay PR #29504 explains why lockout occurs so easily - it's because the threshold is 80 kPa

theres an ancient pr to make lockout smarter

Can you link it

@ArtisticRoomba
Copy link
Contributor

Okay PR #29504 explains why lockout occurs so easily - it's because the threshold is 80 kPa

theres an ancient pr to make lockout smarter

Can you link it

ye ancient PR #29493

@Quantum-cross
Copy link

Please take a look at this draft I just whipped up: #35489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Engineering Area: Engineering department, including Atmospherics. A: Mapping Area: Maps, or tools used for mapping D3: Low Difficulty: Some codebase knowledge required. Issue: Replicated This issue has been replicated by another user. P3: Standard Priority: Default priority for repository items. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Development

No branches or pull requests

10 participants