Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemToggleComponent is hard coupled to PowerCellDrawComponent #31377

Closed
EmoGarbage404 opened this issue Aug 23, 2024 · 2 comments · Fixed by #31392
Closed

ItemToggleComponent is hard coupled to PowerCellDrawComponent #31377

EmoGarbage404 opened this issue Aug 23, 2024 · 2 comments · Fixed by #31392
Labels
D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Refactor Type: Refactor of notable amount of codebase

Comments

@EmoGarbage404
Copy link
Member

Description

The battery won't even drain if you don't have both components on the entity. what the fuck, man.
why do we make events if we're not going to use them.

make a new component that interfaces between both of them.

christ.
@EmoGarbage404 EmoGarbage404 added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Refactor Type: Refactor of notable amount of codebase D3: Low Difficulty: Some codebase knowledge required. labels Aug 23, 2024
@EmoGarbage404
Copy link
Member Author

@deltanedas

@deltanedas
Copy link
Contributor

it should still draw when missing the component, very sus

@deltanedas deltanedas mentioned this issue Aug 24, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Refactor Type: Refactor of notable amount of codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

decouple ItemToggle from PowerCellDraw deltanedas/space-station-14
2 participants
@deltanedas @EmoGarbage404