Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jumpsuits, gloves and shoes look white in the clothesmate #26972

Closed
UbaserB opened this issue Apr 15, 2024 · 3 comments · Fixed by #30064
Closed

Jumpsuits, gloves and shoes look white in the clothesmate #26972

UbaserB opened this issue Apr 15, 2024 · 3 comments · Fixed by #30064
Labels
D3: Low Difficulty: Some codebase knowledge required. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. T: Bugfix Type: Bugs and/or bugfixes

Comments

@UbaserB
Copy link
Member

UbaserB commented Apr 15, 2024

Screenshots

image

image

image

@UbaserB UbaserB added T: Bugfix Type: Bugs and/or bugfixes D3: Low Difficulty: Some codebase knowledge required. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. labels Apr 15, 2024
@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Apr 15, 2024
@UbaserB UbaserB changed the title Jumpsuits look white in the clothesmate Jumpsuits and gloves look white in the clothesmate Apr 15, 2024
@UbaserB UbaserB removed the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Apr 15, 2024
@UbaserB UbaserB changed the title Jumpsuits and gloves look white in the clothesmate Jumpsuits, gloves and shoes look white in the clothesmate Apr 15, 2024
@Hanzdegloker
Copy link
Contributor

casual jumpsuits have had this same issue for a long while, due to the formatting and how the coloured variants are achieved

now we get more of it! sadly...

@Garggamel
Copy link

Noticed that this also is the case for red, blue, and green flannel jackets in the WinterDrobe

@Willhelm53
Copy link
Contributor

I took a look, and I think it's happening because IRsiStateLike does not support the color-override stuff we're now doing for clothing. As others have noted in Discord, adding IconComponent for the individual colors as an override would defeat the purpose of greyscaling them in the first place (#26943).

My theory is that the custom coloring works fine on the dummy, but gets lost in translation when that icon gets passed back to the VendingMachineMenu:

For the VendingMachineMenu (and e.g. the Entity Spawn Panel), the icon is being generated by the GetPrototypeIcon method within SpriteSystem.Specifier. This involves spawning a dummy to get the icon. This part likely works fine, however, the method simply returns an IRsiStateLike. Since the RSI is intentionally greyscale, and no custom coloring information is included in the actual return value, the end result is the default greyscale version of the item icon.

Is this best handled engine-side, or am I perhaps missing a clean approach that could work content-side? I don't want to just complicate VendingMachineMenu and call it a day! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D3: Low Difficulty: Some codebase knowledge required. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants