Fix SplitContainer.MinDraggableWidth not working with mouse-blocking children.
#4439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires space-wizards/space-station-14/pull/20383
This PR reworks how the SplitContainer dragging/resizing interaction works. The main issue with the current implementation is that if the container has children that filter mouse interactions, these interactions prevent the container from being resized as the container is "under" the child. This PR fixes that by making the draggable area a separate control that is placed above the other children.
E.g., on current master if you set the
MinDraggableWidthof the split ui layout to60, the actual draggable area is still tiny, only a few pixels wide:Content.Client_W8W2CAHNCq.mp4
This is how it works if you make that change with this PR.
Content.Client_DzvHngb9dM.mp4