Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix cpu percentage on multi threaded processes #61

Merged
merged 2 commits into from
Jun 11, 2018
Merged

Conversation

simonepri
Copy link
Collaborator

@simonepri simonepri commented Jun 11, 2018

@simonepri simonepri requested a review from soyuka June 11, 2018 19:24
@codecov-io
Copy link

codecov-io commented Jun 11, 2018

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files           9        9           
  Lines         283      283           
=======================================
  Hits          262      262           
  Misses         21       21
Impacted Files Coverage Δ
lib/ps.js 95.34% <ø> (ø) ⬆️
lib/procfile.js 100% <ø> (ø) ⬆️
lib/wmic.js 89.28% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f0c05...eb478da. Read the comment docs.

@soyuka soyuka merged commit f990f72 into master Jun 11, 2018
@soyuka
Copy link
Owner

soyuka commented Jun 11, 2018

These values measure time spent in user and system code respectively, and may end up being greater than actual elapsed time if multiple CPU cores are performing work for this process.

This should be true indeed. We may need to add this to the readme.

@soyuka soyuka deleted the cpu-fix branch April 7, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants