Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing roles #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing roles #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Composer/packages/client/src/pages/home/RecentBotList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export function RecentBotList(props: RecentBotListProps): JSX.Element {
{
key: 'column1',
name: formatMessage('Name'),
role: 'columnheader',
fieldName: 'name',
minWidth: 150,
maxWidth: 200,
Expand All @@ -41,7 +42,7 @@ export function RecentBotList(props: RecentBotListProps): JSX.Element {
data: 'string',
onRender: (item) => {
return (
<div data-is-focusable css={home.tableCell}>
<div data-is-focusable css={home.tableCell} role="columnheader">
<Link
aria-label={formatMessage(`Bot name is {botName}`, { botName: item.name })}
onClick={() => onItemChosen(item)}
Expand All @@ -56,17 +57,19 @@ export function RecentBotList(props: RecentBotListProps): JSX.Element {
{
key: 'column2',
name: formatMessage('Location'),
role: 'columnheader',
fieldName: 'path',
minWidth: 200,
maxWidth: 400,
isResizable: true,
data: 'string',
onRender: (item) => {
return (
<div data-is-focusable css={home.tableCell}>
<div data-is-focusable css={home.tableCell} role="columnheader">
<div
aria-label={formatMessage(`location is {location}`, { location: item.path })}
css={home.content}
role="row"
tabIndex={-1}
>
{item.path}
Expand All @@ -79,17 +82,19 @@ export function RecentBotList(props: RecentBotListProps): JSX.Element {
{
key: 'column3',
name: formatMessage('Date modified'),
role: 'columnheader',
fieldName: 'dateModifiedValue',
minWidth: 60,
maxWidth: 70,
isResizable: true,
data: 'number',
onRender: (item) => {
return (
<div data-is-focusable css={home.tableCell}>
<div data-is-focusable css={home.tableCell} role="columnheader">
<div
aria-label={formatMessage(`Last modified time is {time}`, { time: calculateTimeDiff(item.dateModified) })}
css={home.content}
role="row"
tabIndex={-1}
>
{calculateTimeDiff(item.dateModified)}
Expand Down