Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _wait_for_listening hook from sysvinit script #444

Merged
merged 2 commits into from
May 27, 2017

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented May 27, 2017

This PR partially reverts #433 . Reasons:

  1. The root issue has been fixed by another solution: Remove the notification for consul service restart #443
  2. We can't use consul info call in init script, because it doen't work in Consul 0.8+ with ACL enabled (Update default version to 0.8.3 #434 (comment))

@legal90 legal90 merged commit ed78312 into sous-chefs:master May 27, 2017
@legal90 legal90 deleted the revert-wait-consul branch May 27, 2017 20:12
@codecov-io
Copy link

Codecov Report

Merging #444 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   67.03%   67.03%           
=======================================
  Files           7        7           
  Lines         358      358           
=======================================
  Hits          240      240           
  Misses        118      118

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95be769...3dccaa7. Read the comment docs.

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants