Update unit tests configuration #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
=========================================
Coverage ? 69.46%
=========================================
Files ? 7
Lines ? 357
Branches ? 0
=========================================
Hits ? 248
Misses ? 109
Partials ? 0Continue to review full report at Codecov.
|
Policyfile resolver for ChefSpec requires "chef-dk" gem, which has pretty big dependency tree. So, for unit tests it's better just to use Berkshelf.
|
@johnbellone Do we really need this |
|
@legal90 It should be disabled as of right now. |
johnbellone
approved these changes
Apr 25, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have unit tests failed because of a
cheffishgem conflict (is required bychef-dkgem). This PR removes some unnecessary gem dependencies and introduces Chef Delivery CLI for running tests, like Chef Software does that for their cookbooks.Policyfile resolver for ChefSpec requires "chef-dk" gem, which has pretty big dependency tree.
So, for unit tests it's better just to use Berkshelf.