consul_config: Remove the default value of "server" param

[vsudilov]

closes #423

Wasn't sure how you'd prefer to add tests, since server:false is explicitly set in .kitchen.yml. Happy to iterate on that as needed.

[legal90]

@vsudilov Thanks for your contribution!
However, since the default value is currently hard-coded in the resource, I think we should fix it there, rather then overriding via node's attribute:

https://github.com/johnbellone/consul-cookbook/blame/7b9b75c86ba4963dce6bebd94f289b258942062a/libraries/consul_config.rb#L92

P.s. It should be enough just to remove default: true statement there.

[codecov-io]

Codecov Report

Merging #424 into master will increase coverage by 4.44%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   58.38%   62.82%   +4.44%     
==========================================
  Files           7        7              
  Lines         346      347       +1     
==========================================
+ Hits          202      218      +16     
+ Misses        144      129      -15

Impacted Files	Coverage Δ
libraries/consul_config.rb	97.52% <100%> (+20.02%)	⬆️
libraries/consul_execute.rb	55% <0%> (-45%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9b75c...788641a. Read the comment docs.

[vsudilov]

Yep, agree that's a much better solution -- commit added.

[legal90]

NB: The TravisCI run reveals the very important issue which happens after the removal the default value of "server" attribute (resource parameter).

Since we access this parameter here, it becomes defined with the default value nil, so it is rendered to JSON config file as "server": null, which is not valid.
I've fixed that by removing nil values right before rendering the JSON config file.
@vsudilov I've updated this PR by adding commits to your branch. Now Travis build is green

@johnbellone Please, review this PR.

[vsudilov]

Thanks :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.