Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct acl creation #272

Merged
merged 1 commit into from
Feb 8, 2016
Merged

Correct acl creation #272

merged 1 commit into from
Feb 8, 2016

Conversation

kamaradclimber
Copy link
Contributor

Otherwise the diplomat gem raise an exception

@codecov-io
Copy link

Current coverage is 49.34%

Merging #272 into master will increase coverage by +0.13% as of b59cb4a

@@            master    #272   diff @@
======================================
  Files            7       7       
  Stmts          380     381     +1
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            187     188     +1
  Partial          0       0       
  Missed         193     193       

Review entire Coverage Diff as of b59cb4a

Powered by Codecov. Updated on successful CI builds.

@johnbellone
Copy link
Contributor

Unfortunately our coverage here isn't the best. Would you be able to explain the change?

@kamaradclimber
Copy link
Contributor Author

Diplomat::Acl.info expect a third parameter which gives the behavior if the acl does not exist. The default behavior is to raise an exception.

See https://github.com/WeAreFarmGeek/diplomat/blob/master/lib/diplomat/acl.rb#L15, I'll put this into the commit message.

Otherwise the diplomat gem raise an exception.

Diplomat::Acl.info expects a third argument to specify the behavior when
the acl does not exist. Default value is to raise an exception.

also updates the rubocop rule name to make test pass
@johnbellone
Copy link
Contributor

Thanks!

johnbellone added a commit that referenced this pull request Feb 8, 2016
@johnbellone johnbellone merged commit c390fcc into sous-chefs:master Feb 8, 2016
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants