Add custom template for "sysvinit" service provider #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -48,7 +48,7 @@ def command(config_file, config_dir) | |||
| if windows? | |||
| %{agent -config-file="""#{config_file}""" -config-dir="""#{config_dir}"""} | |||
| else | |||
| "/usr/bin/env consul agent -config-file=#{config_file} -config-dir=#{config_dir}" | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
johnbellone
added a commit
that referenced
this pull request
Jan 28, 2016
Add custom template for "sysvinit" service provider
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default template looks very tricky and it doesn't work well on RHEL 6: there are some artifacts in the console output while we are doing
service consul <stop | start>:https://github.com/poise/poise-service/blob/d9a5135dbe5711214c377c8ee2e7af029b1f10b7/chef/templates/default/sysvinit.sh.erb
This PR adds a custom template for
sysvinitprovider which looks pretty clear and works fine.It was inspired by the init script form "consul-rpm" project: consul.init
Verified on CentOS 6.7 and Debian 7.9
P.s. This PR could be related to #235, but it doesn't fix that issue. For RHEL/CentOS 6 we still have to set provider to
:sysvinitin explicit to avoid the usage of:upstart(#235 (comment)).