-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create config files in config_dir #265
Conversation
Current coverage is
|
👍 good catch. |
provides(:consul_watch) | ||
default_action(:create) | ||
|
||
# @!attribute path | ||
# @return [String] | ||
attribute(:path, kind_of: String, default: lazy { "/etc/consul/#{name}.json" }) | ||
attribute(:path, kind_of: String, default: lazy { join_path node['consul']['service']['config_dir'], "#{name}.json" }) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Take a look at my above comments. Let's get this merged and I think this is the last big obstacle for the 1.4 release. |
I favoured the node value for a couple reasons:
Not a huge issue to me either way, though. |
Create config files in config_dir
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
So that they can be found and loaded by the Consul agent