Add attributes to configure Consul ports

[jubianchi]

No description provided.

[coveralls]

Coverage remained the same when pulling f1e4da4 on jubianchi:consul-ports into 3548309 on johnbellone:master.

[johnbellone]

@reset Any thoughts?

[reset]

@johnbellone this accomplishes the goal but the overall approach we're using to configure the service isn't very safe in the first place. I'd say this is safe to merge in but we should look at validating our attributes to raise awareness at the start of a chef run, not in the middle of it, of misconfigured attributes.

[johnbellone]

@reset What's the best way to verify the attributes?

[reset]

@johnbellone unfortunately the attributes you define in the metadata of the cookbook don't actually enforce anything... that would be the ideal place. So instead I just write Ruby modules in a Library that take the node object and perform validation on all the things that I expect a node to have.

Honestly we (as a community) need to help improve this and make cookbook metadata define the rules and then have them run at convergence time.

[johnbellone]

@jubianchi Can you rebase?

[coveralls]

Coverage decreased (-3.95%) when pulling b8bfa3d on jubianchi:consul-ports into 3643ab6 on johnbellone:master.

[coveralls]

Coverage remained the same when pulling 0274688 on jubianchi:consul-ports into 3643ab6 on johnbellone:master.

[jubianchi]

@johnbellone done!

[jubianchi]

👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.