Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough draft of a resource to provide ACL support using the
diplomat
gem as an API client. It's not ready to merge yet since there's no unit tests, etc... however I wanted to throw it out there for comments and suggestions.Since most of the work is being handled by diplomat there's really not much to it. It's passing the included integration tests, is idempotent, notifies correctly, etc.
A few noteworthy points:
consul::client_gem
recipe is included with the cookbook to do the needful.:update
... just:create
and:delete
. After tinkering with the Consul API for awhile it looks like the only difference between create and update in Consul's API is the fact that create can be called without an ID (it'll create the ACL with a random UUID if ID is not provided). So, to keep things simple/predictable the create endpoint is used for create/update and an ID is required.Comments? Thanks!