Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to specify explicit service name other that filename #227

Merged
merged 1 commit into from
Oct 6, 2015

Conversation

tomzo
Copy link
Contributor

@tomzo tomzo commented Oct 4, 2015

Just a small fix so that name of service can be different that name of chef resource:

consul_definition 'redis' do
        type 'service'
        parameters(
           name: 'myredis', # <<<--- this had no effect before
           tags: %w{master}, 
           address: '127.0.0.1', 
           port: 6379,
           interval: '10s')
end

All covered in tests. Without this change the case would fail

all functionality covered in tests, without this change the case would
fail
@codecov-io
Copy link

Current coverage is 55.07%

Merging #227 into master will decrease coverage by -4.06% as of 96af211

@@            master    #227   diff @@
======================================
  Files            6       6       
  Stmts          323     325     +2
  Branches         0       0       
  Methods          0       0       
======================================
- Hit            191     179    -12
  Partial          0       0       
- Missed         132     146    +14

Review entire Coverage Diff as of 96af211

Powered by Codecov. Updated on successful CI builds.

johnbellone added a commit that referenced this pull request Oct 6, 2015
support to specify explicit service name other that filename
@johnbellone johnbellone merged commit ca47a08 into sous-chefs:master Oct 6, 2015
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants