Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect stderr to syslog and do some cosmetical changes #115

Merged
merged 1 commit into from
Mar 14, 2015

Conversation

akerekes
Copy link
Contributor

@akerekes akerekes commented Feb 2, 2015

These changes were introduced by #91 (among others). I've split that PR into smaller chunks in hope for easier merge.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 06d517e on akerekes:redirect_stderr_to_syslog into e332fc9 on johnbellone:master.

@johnbellone
Copy link
Contributor

Please keep in mind that on most Linux distributions this is merely a symlink. On Ubuntu I believe that /bin/sh is a symlink to dash by default.

@akerekes
Copy link
Contributor Author

akerekes commented Feb 5, 2015

The important changes are lines 1 and 43, bash is needed for stderr redirection, and stderr redirection is needed to avoid losing information dumped to stderr.
The other two changes, line 23 and 44 are just cosmetic, I can remove them if you want.

@akerekes
Copy link
Contributor Author

akerekes commented Feb 9, 2015

@johnbellone Did I answer your question?

@johnbellone
Copy link
Contributor

Can you please rebase?

@akerekes akerekes force-pushed the redirect_stderr_to_syslog branch from 06d517e to 77b2fd9 Compare February 11, 2015 19:57
@akerekes
Copy link
Contributor Author

I did. This is my first time to rebase a pull request, please verify it whether it looks good, pls.

@akerekes
Copy link
Contributor Author

@johnbellone do you have any estimates when can this PR be merged? Thanks!

@adgaudio adgaudio mentioned this pull request Mar 4, 2015
@johnbellone johnbellone added this to the 0.9.0 release milestone Mar 14, 2015
johnbellone added a commit that referenced this pull request Mar 14, 2015
redirect stderr to syslog and do some cosmetical changes
@johnbellone johnbellone merged commit 5208d86 into sous-chefs:master Mar 14, 2015
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants