Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making it work with golang cookbook 1.4.0 #101

Merged
merged 1 commit into from
Dec 17, 2014

Conversation

opsline-radek
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ff75982 on opsline:golang-depends-update into 8dc6de1 on johnbellone:master.

@reset
Copy link
Contributor

reset commented Dec 16, 2014

@opsline-radek it's preferred to lock to a minor version instead of anything greater than. Would you mind changing it to ~> 1.4 instead? Thank you!

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c32d63a on opsline:golang-depends-update into 8dc6de1 on johnbellone:master.

@reset
Copy link
Contributor

reset commented Dec 16, 2014

@opsline-radek thanks!

@reset
Copy link
Contributor

reset commented Dec 16, 2014

@opsline-radek it looks like the test failures are due to this change. Could you update those specs as well?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4a6abe3 on opsline:golang-depends-update into 8dc6de1 on johnbellone:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling e5e0f3f on opsline:golang-depends-update into 8dc6de1 on johnbellone:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ba27d83 on opsline:golang-depends-update into 8d34e11 on johnbellone:master.

reset added a commit that referenced this pull request Dec 17, 2014
making it work with golang cookbook 1.4.0
@reset reset merged commit 0e2f76a into sous-chefs:master Dec 17, 2014
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants