-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: add additional weighted information to manysearch
output
#388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctb
changed the title
WIP: add weighted information to
MRG: add weighted information to Jul 12, 2024
manysearch
outputmanysearch
output
@bluegenes this took me a minute 😆 . Let me know what you think! |
Ready for review & merge! |
ctb
changed the title
MRG: add weighted information to
MRG: add additional weighted information to Jul 14, 2024
manysearch
outputmanysearch
output
bluegenes
approved these changes
Jul 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you know, this direction makes a lot more sense. lgtm!
This was referenced Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #380
Note: in #302, the meaning of 'query' and 'against' was flipped. For
manysearch
, unlike ingather
/prefetch
, 'query' is meant to be the genome andagainst
is meant to be the metagenome. This PR switches them back, so that themgmanysearch
command line from the containment search plugin matches themanysearch
command line:vs
where
query.txt
containsf_prausnitzii.sig.zip\nb_uniformis.sig.zip
(the genomes) andagainst.txt
contains theCD*.sig.zip
files (the metagenomes).Using the display code in #380 to display
search2.csv
, we then get:which matches the mgmanysearch output: