Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastmultigather doesn't properly report # of sigs searched #285

Closed
ctb opened this issue Mar 22, 2024 · 0 comments · Fixed by #320
Closed

fastmultigather doesn't properly report # of sigs searched #285

ctb opened this issue Mar 22, 2024 · 0 comments · Fixed by #320

Comments

@ctb
Copy link
Collaborator

ctb commented Mar 22, 2024 

gathering all sketches in '../podar-ref-singleton.zip' against 'podar-ref.rocksdb' using 8 threads
Loaded DB
Reading query(s) from: '../podar-ref-singleton.zip'
Loaded 490 query signature(s)
DONE. Processed 0 search sigs
...fastmultigather is done!

Number of search sigs should be larger than 0 :)
@ctb ctb mentioned this issue May 4, 2024
Merged
@ctb ctb changed the title fastmultigather doesn't properly report # of sigs fastmultigather doesn't properly report # of sigs searched May 4, 2024
bluegenes added a commit that referenced this issue May 8, 2024
@ctb @bluegenes
MRG: fix lint error, & processed sig reporting for rocksdb/fastmultig…
f07d3a5 
…ather (#320)

Fixes #313
Fixes #285

Addresses #239 / #299 by bailing out when an output path is provided but will not be used:
```
RuntimeError: output path specified, but not running fastmultigather against a rocksdb. See 
issue #239
```
although we are leaning towards respecting `-o` in the future, see #299 discussion, so this will soon get revisited.
---------

Co-authored-by: Tessa Pierce Ward <bluegenes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ctb