Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump criterion from 0.3.6 to 0.5.1 #2629

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 29, 2023

Bumps criterion from 0.3.6 to 0.5.1.

Changelog

Sourced from criterion's changelog.

[0.5.1] - 2023-05-26

Fixed

  • Quick mode (--quick) no longer crashes with measured times over 5 seconds when --noplot is not active

[0.5.0] - 2023-05-23

Changed

  • Replaced lazy_static dependency with once_cell
  • Improved documentation of the html_reports feature
  • Replaced atty dependency with is-terminal
  • MSRV bumped to 1.64
  • Upgraded clap dependency to v4
  • Upgraded tempfile dependency to v3.5.0

Fixed

  • Quick mode (--quick) no longer outputs 1ms for measured times over 5 seconds
  • Documentation updates

[0.4.0] - 2022-09-10

Removed

  • The Criterion::can_plot function has been removed.
  • The Criterion::bench_function_over_inputs function has been removed.
  • The Criterion::bench_functions function has been removed.
  • The Criterion::bench function has been removed.

Changed

  • HTML report hidden behind non-default feature flag: 'html_reports'
  • Standalone support (ie without cargo-criterion) feature flag: 'cargo_bench_support'
  • MSRV bumped to 1.57
  • rayon and plotters are optional (and default) dependencies.
  • Status messages ('warming up', 'analyzing', etc) are printed to stderr, benchmark results are printed to stdout.
  • Accept subsecond durations for --warm-up-time, --measurement-time and --profile-time.
  • Replaced serde_cbor with ciborium because the former is no longer maintained.
  • Upgrade clap to v3 and regex to v1.5.

Added

  • A --discard-baseline flag for discarding rather than saving benchmark results.
  • Formal support for benchmarking code compiled to web-assembly.
  • A --quiet flag for printing just a single line per benchmark.
  • A Throughput::BytesDecimal option for measuring throughput in bytes but printing them using decimal units like kilobytes instead of binary units like kibibytes.

Fixed

  • When using bench_with_input, the input parameter will now be passed through black_box before passing it to the benchmark.
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust labels May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #2629 (a8feee0) into latest (822b79a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           latest    #2629   +/-   ##
=======================================
  Coverage   85.27%   85.27%           
=======================================
  Files         133      133           
  Lines       15170    15170           
  Branches     2612     2612           
=======================================
  Hits        12936    12936           
  Misses       1933     1933           
  Partials      301      301           
Flag Coverage Δ
hypothesis-py 25.81% <ø> (ø)
python 92.83% <ø> (ø)
rust 51.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctb
Copy link
Contributor

ctb commented Jun 1, 2023

@dependabot rebase

Bumps [criterion](https://github.com/bheisler/criterion.rs) from 0.3.6 to 0.5.1.
- [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md)
- [Commits](bheisler/criterion.rs@0.3.6...0.5.1)

---
updated-dependencies:
- dependency-name: criterion
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/criterion-0.5.1 branch from 182cada to a8feee0 Compare June 1, 2023 15:10
@ctb ctb enabled auto-merge (squash) June 1, 2023 15:44
@ctb ctb merged commit 5911fb2 into latest Jun 1, 2023
@ctb ctb deleted the dependabot/cargo/criterion-0.5.1 branch June 1, 2023 15:50
luizirber added a commit that referenced this pull request Jul 18, 2023
Rust 1.72 beta introduced new clippy lints that are failing on CI, most
of them are easy to fix (remove ` as` conversion), but [the one
changing](https://rust-lang.github.io/rust-clippy/master/index.html#/arc_with_non_send_sync)
```
pub struct InnerStorage(Arc<Mutex<dyn Storage>>);
```
to
```
pub struct InnerStorage(Rc<RwLock<dyn Storage>>);
```
is a bit more involved. Still need to better evaluate how this will go
with threads, but since it is an opaque type we can also change the
internal representation without breaking semver.

#2629 introduced an MSRV
bump to 1.64 on the test dependencies, added an extra argument `--tests`
in the CI checks to verify test deps too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant