Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] fix kreport documentation #2302

Merged
merged 3 commits into from
Sep 28, 2022
Merged

[MRG] fix kreport documentation #2302

merged 3 commits into from
Sep 28, 2022

Conversation

bluegenes
Copy link
Contributor

kreport documentation had a legacy note about abundance-weighting issues that are now solved. This fixes that note and expands the explanation slightly.

I also replaced the example output with results from a real file rather than the test data results that were mostly unclassified.

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #2302 (3c5fe99) into latest (d90c722) will increase coverage by 7.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           latest    #2302      +/-   ##
==========================================
+ Coverage   84.76%   92.04%   +7.27%     
==========================================
  Files         131      100      -31     
  Lines       15676    11403    -4273     
  Branches     2252     2252              
==========================================
- Hits        13288    10496    -2792     
+ Misses       2093      612    -1481     
  Partials      295      295              
Flag Coverage Δ
python 92.04% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/tests/test.rs
src/core/src/ffi/index/mod.rs
src/core/src/ffi/utils.rs
src/core/src/ffi/storage.rs
src/core/src/index/sbt/mhbt.rs
src/core/src/index/mod.rs
src/core/src/encodings.rs
src/core/tests/storage.rs
src/core/src/ffi/minhash.rs
src/core/src/ffi/cmd/compute.rs
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@bluegenes bluegenes merged commit 719e7d5 into latest Sep 28, 2022
@bluegenes bluegenes deleted the kreport-doc branch September 28, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants