[MRG] clean up zip error handling for bad zip files #2270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SaveSignatures_*
andZipStorage
have some ugly and slightly broken error handling when trying to open a.zip
file that is not, in fact, a valid zipfile. This made it hard to figure out what the actual error was!This PR cleans up the error handling to present the user with a somewhat more useful error message.
Fixes #2269