Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] fix plot label order for stdout and --csv output #1821

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Feb 2, 2022

This PR corrects the label order that sourmash plot outputs to stdout and --csv. The actual figure labels were and remain correct.

Plus, and just as importantly, this PR provides a test that actually checks that the order is correct :).

Fixes #1605.

@ctb
Copy link
Contributor Author

ctb commented Feb 2, 2022

@taylorreiter ready for review. I'll verify that the tests are only breaking because of non-PR related stuff before merging.

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #1821 (b9dbe96) into latest (5bd2e35) will increase coverage by 6.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1821      +/-   ##
==========================================
+ Coverage   83.48%   90.15%   +6.67%     
==========================================
  Files         113       87      -26     
  Lines       12183     8482    -3701     
  Branches     1627     1627              
==========================================
- Hits        10171     7647    -2524     
+ Misses       1754      577    -1177     
  Partials      258      258              
Flag Coverage Δ
python 90.15% <100.00%> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/fig.py 89.13% <100.00%> (ø)
src/core/src/index/mod.rs
src/core/src/lib.rs
src/core/src/sketch/nodegraph.rs
src/core/src/ffi/cmd/compute.rs
src/core/src/ffi/signature.rs
src/core/src/signature.rs
src/core/src/from.rs
src/core/src/errors.rs
src/core/src/index/linear.rs
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd2e35...b9dbe96. Read the comment docs.

Copy link
Contributor

@taylorreiter taylorreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, LGTM!

@ctb
Copy link
Contributor Author

ctb commented Feb 2, 2022

🎉

@ctb ctb merged commit 9083d20 into latest Feb 2, 2022
@ctb ctb deleted the fix/plot_label_ordering branch February 2, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is the idx reversed for fig labels but not for matrix reordering in fig.py?
2 participants