Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] set pickfile attribute on SourmashPicklist.load(...) #1776

Merged
merged 2 commits into from
Jan 17, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Dec 24, 2021

The load method on SourmashPicklist did not set the pickfile attribute, while the class method from_picklist_args(...) did set it. This PR fixes load to be consistent with from_picklist_args.

Fixes #1773

@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

Merging #1776 (ffcef91) into latest (c9c0303) will increase coverage by 6.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1776      +/-   ##
==========================================
+ Coverage   83.42%   90.10%   +6.67%     
==========================================
  Files         113       87      -26     
  Lines       12140     8440    -3700     
  Branches     1614     1614              
==========================================
- Hits        10128     7605    -2523     
+ Misses       1753      576    -1177     
  Partials      259      259              
Flag Coverage Δ
python 90.10% <100.00%> (+<0.01%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/picklist.py 90.51% <100.00%> (+0.06%) ⬆️
src/core/src/index/sbt/mhbt.rs
src/core/src/index/mod.rs
src/core/src/errors.rs
src/core/src/sketch/nodegraph.rs
src/core/src/ffi/minhash.rs
src/core/src/signature.rs
src/core/src/ffi/utils.rs
src/core/src/index/search.rs
src/core/tests/test.rs
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c0303...ffcef91. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Dec 29, 2021

ready for review @sourmash-bio/devs - the failing dev envs test is not caused by this change, and is being investigated #1778

@ctb ctb merged commit 538c79e into latest Jan 17, 2022
@ctb ctb deleted the update/pickfile_attr branch January 17, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignaturePicklist has a clumsy interaction between the constructor and load method.
2 participants