Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fix panic bug in sourmash sketch dna with bad input and --check-sequence #1702

Merged
merged 5 commits into from
Aug 3, 2021

Conversation

mr-eyes
Copy link
Member

@mr-eyes mr-eyes commented Aug 3, 2021

A PR that fixes #1700

@mr-eyes mr-eyes changed the title [WIP] Fix panic bug in sourmash sketch dna with bad input and --check-sequence [MRG] Fix panic bug in sourmash sketch dna with bad input and --check-sequence Aug 3, 2021
@mr-eyes mr-eyes requested a review from ctb August 3, 2021 01:01
@mr-eyes
Copy link
Member Author

mr-eyes commented Aug 3, 2021

@ctb I think this resolves the issue and is ready for review.

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #1702 (46c4f63) into latest (222f54b) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1702      +/-   ##
==========================================
+ Coverage   82.61%   82.63%   +0.01%     
==========================================
  Files         113      113              
  Lines       11996    11994       -2     
  Branches     1513     1513              
==========================================
  Hits         9911     9911              
+ Misses       1830     1828       -2     
  Partials      255      255              
Flag Coverage Δ
python 90.10% <ø> (ø)
rust 66.49% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/signature.rs 61.27% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 222f54b...46c4f63. Read the comment docs.

@mr-eyes mr-eyes changed the title [MRG] Fix panic bug in sourmash sketch dna with bad input and --check-sequence [WIP] Fix panic bug in sourmash sketch dna with bad input and --check-sequence Aug 3, 2021
@mr-eyes
Copy link
Member Author

mr-eyes commented Aug 3, 2021

re-Renamed to WIP due to a failed rust check.

@mr-eyes mr-eyes changed the title [WIP] Fix panic bug in sourmash sketch dna with bad input and --check-sequence [MRG] Fix panic bug in sourmash sketch dna with bad input and --check-sequence Aug 3, 2021
@ctb
Copy link
Contributor

ctb commented Aug 3, 2021

thank you!

@ctb ctb merged commit cdc1fc6 into latest Aug 3, 2021
@ctb ctb deleted the fix/panic_bug_sig_add_sequence branch August 3, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic bug in sourmash sketch dna with bad input and --check-sequence
2 participants