Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] update a tricky test to use sourmash sketch instead of compute #1687

Merged
merged 3 commits into from
Jul 30, 2021

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jul 27, 2021

Over in #1680 while tackling converting tests from using sourmash compute over to using sourmash sketch, @keyabarve ran into a particularly tricky test that can't be directly converted. This PR rewrites the test to use sourmash sketch to check the same code that the original test was testing, sourmash_args.py::load_query_signatures(...).

@keyabarve happy to wait to merge this until #1680 has been merged, or you can review and merge it now if you like.

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #1687 (151916e) into latest (7f7dbba) will increase coverage by 7.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1687      +/-   ##
==========================================
+ Coverage   82.60%   90.10%   +7.50%     
==========================================
  Files         113       86      -27     
  Lines       11995     8197    -3798     
  Branches     1513     1513              
==========================================
- Hits         9908     7386    -2522     
+ Misses       1832      556    -1276     
  Partials      255      255              
Flag Coverage Δ
python 90.10% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/cmd.rs
src/core/src/ffi/nodegraph.rs
src/core/src/errors.rs
src/core/src/ffi/mod.rs
src/core/tests/test.rs
src/core/src/sketch/minhash.rs
src/core/src/index/bigsi.rs
src/core/src/sketch/hyperloglog/mod.rs
src/core/src/sketch/nodegraph.rs
src/core/src/signature.rs
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f7dbba...151916e. Read the comment docs.

@keyabarve
Copy link
Contributor

@ctb Should I merge this?

@ctb ctb requested a review from keyabarve July 29, 2021 17:47
@ctb
Copy link
Contributor Author

ctb commented Jul 29, 2021

We need a review first. I just sent you a review request via the github interface.

Copy link
Contributor

@keyabarve keyabarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if the comments were supposed to be removed. But otherwise, lgtm!

@ctb
Copy link
Contributor Author

ctb commented Jul 29, 2021

thanks - the only comments I see are ones that explain what the code is doing, which I think are probably fine to leave in there. are there comments that you think we should remove?

@keyabarve
Copy link
Contributor

keyabarve commented Jul 29, 2021

No, I don't think so. Thanks! I'll submit an approving review then.

Copy link
Contributor

@keyabarve keyabarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ctb ctb merged commit 03f28cd into latest Jul 30, 2021
@ctb ctb deleted the update/sketch_test branch July 30, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants