-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] refactor and simplify sourmash sig
subcommand signature loading
#1672
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1672 +/- ##
==========================================
+ Coverage 82.42% 89.99% +7.56%
==========================================
Files 113 86 -27
Lines 11847 8173 -3674
Branches 1507 1508 +1
==========================================
- Hits 9765 7355 -2410
+ Misses 1822 561 -1261
+ Partials 260 257 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ready for review and merge @sourmash-bio/devs! |
sourmash sig
subcommand signature loadingsourmash sig
subcommand signature loading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could use picklist tests for cat
and subtract
...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes #1631
--force
and--from-file
to most ofsig
commands.-k
and moltype arguments to most of thesig
commands.TODO:
split --from-file
downsample --num
on scaled sigdescribe --from-file
merge --from-file
intersect --from-file
rename --from-file
extract --from-file
flatten --from-file
downsample --num --scaled
bothLoadManySignatures
- should it be a generator fn only? should it be insig/__main__.py
only?LoadManySignatures
directly.