[MRG] implement a lazy/on-demand Index loading class
#1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #1661 +/- ##
==========================================
+ Coverage 82.22% 89.68% +7.46%
==========================================
Files 113 86 -27
Lines 11704 8031 -3673
Branches 1478 1483 +5
==========================================
- Hits 9624 7203 -2421
+ Misses 1820 568 -1252
Partials 260 260
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Ready for review & merge @sourmash-bio/devs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
indexLazyLoadedIndex(...)which takes the location of an index + and a manifest, and only opens the index when signatures are needed. In particular,selectcalls are performed on the manifest, and then on index load the manifest is used as a picklist to select out the signatures to be loaded.In brief, this supports low memory tracking of a large index without needing to keep the Index object itself in memory.
(Code originally developed over in #1619)