Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add sig cat --from-file #1657

Merged
merged 4 commits into from
Jul 13, 2021
Merged

[MRG] add sig cat --from-file #1657

merged 4 commits into from
Jul 13, 2021

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jul 9, 2021

Adds --from-file to sig cat per #1631.

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #1657 (e98d2d3) into latest (97fa790) will increase coverage by 7.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1657      +/-   ##
==========================================
+ Coverage   82.22%   89.64%   +7.41%     
==========================================
  Files         113       86      -27     
  Lines       11704     7995    -3709     
  Branches     1478     1479       +1     
==========================================
- Hits         9624     7167    -2457     
+ Misses       1820      568    -1252     
  Partials      260      260              
Flag Coverage Δ
python 89.64% <100.00%> (+<0.01%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/cli/sig/cat.py 100.00% <100.00%> (ø)
src/sourmash/sig/__main__.py 90.98% <100.00%> (+0.07%) ⬆️
src/sourmash/sourmash_args.py 93.43% <100.00%> (ø)
src/core/src/ffi/minhash.rs
src/core/src/index/search.rs
src/core/src/signature.rs
src/core/tests/test.rs
src/core/src/index/sbt/mod.rs
src/core/src/ffi/cmd/compute.rs
src/core/src/index/storage.rs
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97fa790...e98d2d3. Read the comment docs.

@ctb ctb changed the title [WIP] add sig cat --from-file [MRG] add sig cat --from-file Jul 13, 2021
@ctb
Copy link
Contributor Author

ctb commented Jul 13, 2021

Ready for review & merge @sourmash-bio/devs

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bluegenes
Copy link
Contributor

Closes #1631

@ctb ctb merged commit 45f9cd6 into latest Jul 13, 2021
@ctb ctb deleted the add/sig_cat_fromfile branch July 13, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants