Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] fix truncation of tax genome classification #1648

Merged
merged 4 commits into from
Jun 30, 2021
Merged

Conversation

bluegenes
Copy link
Contributor

@bluegenes bluegenes commented Jun 29, 2021

fix bugs in tax genome:

  • continue instead of break (caused genome to truncate classification early)
  • when classifying by threshold, use the match rank rather than args.rank

@bluegenes bluegenes changed the title fix truncation of tax genome classification [MRG] fix truncation of tax genome classification Jun 29, 2021
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #1648 (6d8eb5f) into latest (4fce5ab) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           latest    #1648   +/-   ##
=======================================
  Coverage   81.91%   81.91%           
=======================================
  Files         112      112           
  Lines       11447    11447           
  Branches     1432     1432           
=======================================
  Hits         9377     9377           
  Misses       1813     1813           
  Partials      257      257           
Flag Coverage Δ
python 89.32% <100.00%> (ø)
rust 66.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/tax/__main__.py 89.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fce5ab...6d8eb5f. Read the comment docs.

@ctb ctb merged commit dcfd973 into latest Jun 30, 2021
@ctb ctb deleted the fix-tax-genome branch June 30, 2021 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants