-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Fix selection w/abund and manifest column type conversions #1645
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1645 +/- ##
=======================================
Coverage 81.91% 81.92%
=======================================
Files 112 112
Lines 11447 11462 +15
Branches 1432 1440 +8
=======================================
+ Hits 9377 9390 +13
- Misses 1813 1814 +1
- Partials 257 258 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ready for review and merge @sourmash-bio/devs |
…rmash-bio/sourmash into fix/manifest_types_and_abund
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This PR fixes three issues -
select_signatures(...)
didn't take an abund keyword arg, and manifest selection didn't either;abund
, of course!