Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Prepare new core release (and upload to NPM) #1643

Merged
merged 4 commits into from
Jul 8, 2021

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Jun 27, 2021

Previous discussion at #1625 (comment)

This PR brings some changes from #1625 but sticks with the current approach (no separate crate). It also benefits from wasm-pack 0.10.0, which fixed the problem of missing files in the NPM package.

@gustavo-salazar I tried the artifact from this PR (as 0.11.0) in mgnify-sourmash-component, and it worked without any changes. I will release this as a new Rust/NPM version, with future improvements (like compressed FASTA/Q parsing) incoming.

(Oh, I also added a changelog for the Rust crate)

@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #1643 (196dce2) into latest (2542e6c) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1643      +/-   ##
==========================================
- Coverage   81.89%   81.83%   -0.06%     
==========================================
  Files         112      112              
  Lines       11484    11492       +8     
  Branches     1444     1444              
==========================================
  Hits         9405     9405              
- Misses       1819     1827       +8     
  Partials      260      260              
Flag Coverage Δ
python 89.26% <ø> (ø)
rust 66.28% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/cmd.rs 86.88% <ø> (ø)
src/core/src/encodings.rs 77.77% <ø> (ø)
src/core/src/signature.rs 58.18% <ø> (ø)
src/core/src/sketch/minhash.rs 86.81% <ø> (ø)
src/core/src/wasm.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2542e6c...196dce2. Read the comment docs.

@luizirber luizirber force-pushed the rust_wasm_updates branch 2 times, most recently from dfaca40 to 6409a19 Compare June 27, 2021 18:39
@luizirber luizirber force-pushed the rust_wasm_updates branch 2 times, most recently from f900235 to 52b99c3 Compare July 7, 2021 04:03
@luizirber luizirber force-pushed the rust_wasm_updates branch from 52b99c3 to 0d6bc46 Compare July 7, 2021 04:25
@luizirber luizirber changed the title [WIP] Fix NPM package, add missing files during wasm-pack [MRG] Prepare new core release (and upload to NPM) Jul 8, 2021
@luizirber luizirber merged commit 512d961 into latest Jul 8, 2021
@luizirber luizirber deleted the rust_wasm_updates branch July 8, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant