-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] add picklists to selector protocol and provide initial Index
support
#1588
Conversation
Codecov Report
@@ Coverage Diff @@
## add/picklist #1588 +/- ##
================================================
- Coverage 89.34% 89.16% -0.18%
================================================
Files 76 76
Lines 6717 6739 +22
Branches 1198 1207 +9
================================================
+ Hits 6001 6009 +8
- Misses 507 514 +7
- Partials 209 216 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Index
supportIndex
support
Codecov Report
@@ Coverage Diff @@
## latest #1588 +/- ##
==========================================
+ Coverage 81.19% 81.29% +0.10%
==========================================
Files 103 103
Lines 10423 10485 +62
Branches 1198 1217 +19
==========================================
+ Hits 8463 8524 +61
- Misses 1751 1753 +2
+ Partials 209 208 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Index
supportIndex
support
Ready for review @bluegenes. There's a few minor issues to do with our test infrastructure that I'll deal with before considering merge, but the PR is feature complete ;) |
ok, tests are actually passing now, too! Ready for review and maybe merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! looking forward to actually playing around with picklists soon :)
thank you!! |
This PR adds picklists (#1587) into the selector protocol so that
Index.signatures(...)
andIndex.find(...)
both respect picklists, and also introduces it throughout the command-line interface.In detail, this PR:
Index.select(...)
to support apicklist
keyword argument and adds picklist support to the mainIndex
subclasses;SBT.select(...)
andLCA_Database.select(...)
as well;load_file_as_signatures(...)
sourmash sig extract
to pass its picklist intoload_file_as_signatures(...)
, rather than do ad hoc picklisting;--picklist
support tocompare
,gather
,index
,lca index
,prefetch
, andsearch
Note, I decided against adding picklists to
lca summarize
andlca classify
for now, since I think we may be end-of-life-ing LCA databases soon.This does not implement any optimizations for picklist-intersected database searches yet, but they are coming - see #1590!
TODO: