Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add query info to gather CSV output #1565

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jun 2, 2021

Adds query_filename, query_name, query_md5, and query_bp to sourmash gather CSV output.

Fixes #1247 (comment) for gather output.

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #1565 (ef0b7b7) into latest (e2dca11) will increase coverage by 8.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1565      +/-   ##
==========================================
+ Coverage   81.03%   89.14%   +8.11%     
==========================================
  Files         102       75      -27     
  Lines       10294     6598    -3696     
  Branches     1165     1165              
==========================================
- Hits         8342     5882    -2460     
+ Misses       1744      508    -1236     
  Partials      208      208              
Flag Coverage Δ
python 89.14% <100.00%> (+<0.01%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/commands.py 86.27% <ø> (ø)
src/sourmash/search.py 96.33% <100.00%> (+0.06%) ⬆️
src/core/src/errors.rs
src/core/src/ffi/hyperloglog.rs
src/core/src/sketch/hyperloglog/mod.rs
src/core/src/index/search.rs
src/core/src/encodings.rs
src/core/src/ffi/mod.rs
src/core/src/index/sbt/mhbt.rs
src/core/src/ffi/utils.rs
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2dca11...ef0b7b7. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Jun 2, 2021

Ready for review, @bluegenes @taylorreiter @keyabarve @hehouts

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo, query names!

thanks - looks great :)

@ctb ctb merged commit bfe7c40 into latest Jun 2, 2021
@ctb ctb deleted the add/query_info_to_gather_csv branch June 2, 2021 13:46
@bluegenes bluegenes mentioned this pull request Jun 10, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add name, md5 of query signature to gather and search output
2 participants