Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fixing tests that fail to close files that they open #1550

Merged
merged 1 commit into from
May 24, 2021
Merged

Conversation

keyabarve
Copy link
Contributor

Fixes #1435

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #1550 (efdcd2d) into latest (83954d1) will increase coverage by 4.98%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1550      +/-   ##
==========================================
+ Coverage   90.26%   95.25%   +4.98%     
==========================================
  Files         126       99      -27     
  Lines       21268    17571    -3697     
  Branches     1595     1595              
==========================================
- Hits        19198    16737    -2461     
+ Misses       1843      607    -1236     
  Partials      227      227              
Flag Coverage Δ
python 95.25% <100.00%> (+<0.01%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_lca.py 99.87% <100.00%> (+<0.01%) ⬆️
src/core/src/from.rs
src/core/src/sketch/minhash.rs
src/core/tests/test.rs
src/core/src/encodings.rs
src/core/src/errors.rs
src/core/src/sketch/hyperloglog/mod.rs
src/core/src/index/sbt/mod.rs
src/core/src/ffi/utils.rs
src/core/src/lib.rs
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83954d1...efdcd2d. Read the comment docs.

@keyabarve
Copy link
Contributor Author

Please review. @ctb

Copy link
Contributor

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! shall I merge? (put [MRG] in front of PR title if you want me to merge, or [WIP] in front of title if it remains a work-in-progress)

@keyabarve keyabarve changed the title Fixing tests that fail to close files that they open [MRG]Fixing tests that fail to close files that they open May 24, 2021
@keyabarve
Copy link
Contributor Author

Thanks! Sure!

@keyabarve keyabarve changed the title [MRG]Fixing tests that fail to close files that they open [MRG] Fixing tests that fail to close files that they open May 24, 2021
@ctb ctb merged commit 516dc53 into latest May 24, 2021
@ctb ctb deleted the KB_1435 branch May 24, 2021 20:42
@ctb
Copy link
Contributor

ctb commented May 24, 2021

thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix tests that fail to close files that they open
2 participants