cargo clippy beta is failing as of Mar 19, 2024

[ctb]

error: the item `Signature` is imported redundantly
Error:  --> src/core/src/collection.rs:9:5
  |
8 | use crate::prelude::*;
  |     ----------------- the item `Signature` is already imported here
9 | use crate::signature::Signature;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(unused_imports)]`

error: the item `Storage` is imported redundantly
Error:   --> src/core/src/collection.rs:10:69
   |
8  | use crate::prelude::*;
   |     ----------------- the item `Storage` is already imported here
9  | use crate::signature::Signature;
10 | use crate::storage::{FSStorage, InnerStorage, MemStorage, SigStore, Storage, ZipStorage};
   |                                                                     ^^^^^^^

error: the item `TryFrom` is imported redundantly
Error:  --> src/core/src/encodings.rs:3:5
  |
3 | use std::convert::TryFrom;
  |     ^^^^^^^^^^^^^^^^^^^^^
 --> /rustc/efd9d2df12b5e17fac0b4d0fb89f612ecd79f259/library/std/src/prelude/mod.rs:129:13
  |
  = note: the item `TryFrom` is already defined here

error: the item `Iterator` is imported redundantly
Error:  --> src/core/src/encodings.rs:5:5
  |
5 | use std::iter::Iterator;
  |     ^^^^^^^^^^^^^^^^^^^
 --> /rustc/efd9d2df12b5e17fac0b4d0fb89f612ecd79f259/library/std/src/prelude/mod.rs:129:13
  |
  = note: the item `Iterator` is already defined here

error: the item `TryInto` is imported redundantly
Error:  --> src/core/src/manifest.rs:1:5
  |
1 | use std::convert::TryInto;
  |     ^^^^^^^^^^^^^^^^^^^^^
 --> /rustc/efd9d2df12b5e17fac0b4d0fb89f612ecd79f259/library/std/src/prelude/mod.rs:129:13
  |
  = note: the item `TryInto` is already defined here

error: the item `Signature` is imported redundantly
Error:   --> src/core/src/manifest.rs:15:24
   |
14 | use crate::prelude::*;
   |     ----------------- the item `Signature` is already imported here
15 | use crate::signature::{Signature, SigsTrait};
   |                        ^^^^^^^^^

error: the item `Iterator` is imported redundantly
Error:  --> src/core/src/signature.rs:9:5
  |
9 | use std::iter::Iterator;
  |     ^^^^^^^^^^^^^^^^^^^
 --> /rustc/efd9d2df12b5e17fac0b4d0fb89f612ecd79f259/library/std/src/prelude/mod.rs:129:13
  |
  = note: the item `Iterator` is already defined here

error: the item `Select` is imported redundantly
Error:   --> src/core/src/signature.rs:21:24
   |
20 | use crate::prelude::*;
   |     ----------------- the item `Select` is already imported here
21 | use crate::selection::{Select, Selection};
   |                        ^^^^^^

error: the item `Selection` is imported redundantly
Error:   --> src/core/src/signature.rs:21:32
   |
20 | use crate::prelude::*;
   |     ----------------- the item `Selection` is already imported here
21 | use crate::selection::{Select, Selection};
   |                                ^^^^^^^^^

error: the item `Iterator` is imported redundantly
Error:  --> src/core/src/sketch/minhash.rs:5:17
  |
5 | use std::iter::{Iterator, Peekable};
  |                 ^^^^^^^^
 --> /rustc/efd9d2df12b5e17fac0b4d0fb89f612ecd79f259/library/std/src/prelude/mod.rs:129:13
  |
  = note: the item `Iterator` is already defined here

error: struct `Union` is never constructed
Error:    --> src/core/src/sketch/minhash.rs:945:8
    |
945 | struct Union<T, I: Iterator<Item = T>> {
    |        ^^^^^
    |
    = note: `-D dead-code` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(dead_code)]`

error: could not compile `sourmash` (lib) due to 11 previous errors
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

[ctb]

@luizirber @bluegenes I don't know what this means:

error: struct `Union` is never constructed
Error:    --> src/core/src/sketch/minhash.rs:945:8
    |
945 | struct Union<T, I: Iterator<Item = T>> {
    |        ^^^^^
    |
    = note: `-D dead-code` implied by `-D warnings`

any help much appreciated :).

[ctb]

oh, looks like it just means that the code's not used at all! removed it in 3d4b748