Skip to content

Commit

Permalink
Merge branch 'latest' of https://github.com/sourmash-bio/sourmash int…
Browse files Browse the repository at this point in the history
…o fix/dib_lab
  • Loading branch information
ctb committed Apr 30, 2023
2 parents 8b177e7 + 9a7bafe commit 4950f95
Show file tree
Hide file tree
Showing 7 changed files with 44 additions and 25 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_wheel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
python-version: '3.9'

- name: Build wheels
uses: pypa/cibuildwheel@v2.12.1
uses: pypa/cibuildwheel@v2.12.3
env:
CIBW_ENVIRONMENT_MACOS: ${{ matrix.macos_target }}
CIBW_ARCHS_LINUX: ${{ matrix.arch }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_wheel_all_archs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
platforms: all

- name: Build wheels
uses: pypa/cibuildwheel@v2.12.1
uses: pypa/cibuildwheel@v2.12.3
env:
CIBW_ENVIRONMENT_MACOS: ${{ matrix.macos_target }}
CIBW_ARCHS_LINUX: ${{ matrix.arch }}
Expand Down
15 changes: 10 additions & 5 deletions doc/release.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ After release to PyPI and conda-forge/bioconda packages built:
- [ ] [PyPI page](https://pypi.org/project/sourmash/) updated
- [ ] Zenodo DOI successfully minted upon new github release - [see search results](https://zenodo.org/search?page=1&size=20&q=sourmash&sort=mostrecent)
- [ ] `pip install sourmash` installs the correct version
- [ ] [conda-forge sourmash-minimal-feedstock](https://github.com/conda-forge/sourmash-minimal-feedstock) has updated `sourmash-minimal` to the correct version
- [ ] `mamba create -n smash-release -y sourmash` installs the correct version
```

Expand Down Expand Up @@ -105,7 +106,7 @@ sed -i -e "s|version = .*$|version = \"${new_version}\";|g" flake.nix
Commit the changes and push the branch:
```
git add pyproject.toml flake.nix
git commit -m "${new_version} release"
git commit -m "${new_version} release branch"
git push -u origin release/v${new_version}
```
and then open a PR for the new branch by following the link printed by
Expand Down Expand Up @@ -137,7 +138,7 @@ python -m venv testenv4
cd testenv1
source bin/activate
git clone --depth 1 --branch v${new_version}${rc} https://github.com/sourmash-bio/sourmash.git
git clone --depth 1 --branch release/v${new_version} https://github.com/sourmash-bio/sourmash.git
cd sourmash
python -m pip install -r requirements.txt
pytest && cargo test
Expand All @@ -148,7 +149,7 @@ cd ../../testenv2
deactivate
source bin/activate
python -m pip install build
python -m pip install -e git+https://github.com/sourmash-bio/sourmash.git@v${new_version}${rc}#egg=sourmash[test]
python -m pip install -e git+https://github.com/sourmash-bio/sourmash.git@release/v${new_version}#egg=sourmash[test]
cd src/sourmash
pytest && cargo test
make dist
Expand Down Expand Up @@ -177,7 +178,7 @@ Wait for the
[various cibuildwheel actions](https://github.com/sourmash-bio/sourmash/actions)
to finish and upload; the
[latest release](https://github.com/sourmash-bio/sourmash/releases)
should have eight wheel files attached to it.
should have nine wheel files attached to it.

6\. Remove release candidate tags

Expand Down Expand Up @@ -206,7 +207,7 @@ git pull --rebase
2\. Create the final tag and push to GitHub:

```
git tag -a v${new_version} -m "${new_version} release"
git tag -a v${new_version} -m "${new_version} release tag"
git push --tags origin
```

Expand Down Expand Up @@ -302,3 +303,7 @@ Examples:
- [2.1.0](https://twitter.com/luizirber/status/1166910335120314369)
- [2.0.1](https://twitter.com/luizirber/status/1136786447518711808)
- [2.0.0](https://twitter.com/luizirber/status/1108846466502520832)

## After release

Update version to next minor version + `-dev`, e.g. [this PR](https://github.com/sourmash-bio/sourmash/pull/2584).
42 changes: 30 additions & 12 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ exclude = [
]
features = ["maturin"]
locked = true
module-name = "sourmash._lowlevel"

[tool.isort]
known_third_party = ["deprecation", "hypothesis", "mmh3", "numpy", "pytest", "screed", "sourmash_tst_utils"]
Expand Down
3 changes: 0 additions & 3 deletions src/core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,3 @@ wasm-bindgen-test = "0.3.34"

### These crates don't compile on wasm
[target.'cfg(not(all(target_arch = "wasm32", target_os="unknown")))'.dependencies]

[package.metadata.maturin]
name = "sourmash._lowlevel"
4 changes: 1 addition & 3 deletions src/core/src/sketch/nodegraph.rs
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,7 @@ impl Nodegraph {
//wtr.write_u32_from::<LittleEndian>(&count.as_slice()[..div])?;
let slice = &count.as_slice()[..div];
let buf = unsafe {
use std::mem::size_of;

let len = size_of::<u32>() * slice.len();
let len = std::mem::size_of_val(slice);
slice::from_raw_parts(slice.as_ptr() as *const u8, len)
};
wtr.write_all(buf)?;
Expand Down

0 comments on commit 4950f95

Please sign in to comment.