Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scj/update/executor validate #974

Merged
merged 8 commits into from
Apr 24, 2023
Merged

Scj/update/executor validate #974

merged 8 commits into from
Apr 24, 2023

Conversation

scjohns
Copy link
Contributor

@scjohns scjohns commented Apr 21, 2023

Test plan

  • Confirm that adding executor.enabled: true to vaildate.yaml will check live executor connections
  • Confirm that omitting will skip executor connection validation

@scjohns scjohns requested a review from jdpleiness April 21, 2023 14:53
jasonhawkharris
jasonhawkharris approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@jasonhawkharris jasonhawkharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I made one note about preferences but I think the note generally lines up with convention.

internal/validate/install/install.go Outdated Show resolved Hide resolved
internal/validate/install/install.go Outdated Show resolved Hide resolved
@scjohns scjohns merged commit a15767a into main Apr 24, 2023
@scjohns scjohns deleted the scj/update/executor-validate branch April 24, 2023 16:34
camdencheek pushed a commit that referenced this pull request Apr 24, 2023
@scjohns @camdencheek
Scj/update/executor validate (#974)
9a730a1 
* add executor option for src validate install

* remove commented code, remove  option

* remove binary

* lint

* update error int to -1
camdencheek pushed a commit that referenced this pull request Apr 24, 2023
@scjohns @camdencheek
Scj/update/executor validate (#974)
4eff6b7 
* add executor option for src validate install

* remove commented code, remove  option

* remove binary

* lint

* update error int to -1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonhawkharris jasonhawkharris jasonhawkharris approved these changes

@jdpleiness jdpleiness Awaiting requested review from jdpleiness

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scjohns @jasonhawkharris