Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batches: add SRC_HEADERS for passing multiple custom headers #796

Merged
merged 11 commits into from
Jun 30, 2022
Merged

batches: add SRC_HEADERS for passing multiple custom headers #796

merged 11 commits into from
Jun 30, 2022

Conversation

BolajiOlajide
Copy link
Contributor

@BolajiOlajide BolajiOlajide commented Jun 28, 2022 •
edited
Loading

Test plan

  • Added Tests
  • Tested on the following shell
  • bash
  • zsh
  • fish
  • Powershell

2022-06-30 08 31 59

Closes #749

@BolajiOlajide BolajiOlajide self-assigned this Jun 28, 2022
@BolajiOlajide BolajiOlajide marked this pull request as draft June 28, 2022 22:58
@BolajiOlajide BolajiOlajide marked this pull request as ready for review June 28, 2022 23:50
@BolajiOlajide BolajiOlajide requested a review from a team June 28, 2022 23:56
LawnGnome
LawnGnome approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@LawnGnome LawnGnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of trivial nits, but LGTM otherwise.

Not a blocker, but probably worth at least thinking slightly about: do we have any idea how this would go on Windows? If the answer is "it won't work", that's fine, but we should probably call it out in WINDOWS.md.

AUTH_PROXY.md Show resolved Hide resolved
cmd/src/headers.go Outdated Show resolved Hide resolved
@BolajiOlajide BolajiOlajide force-pushed the bo/allow-custom-headers-with-dashes branch from df0abc9 to c9070ac Compare June 29, 2022 15:39
@BolajiOlajide BolajiOlajide merged commit 237e58a into main Jun 30, 2022
@BolajiOlajide BolajiOlajide deleted the bo/allow-custom-headers-with-dashes branch June 30, 2022 07:37
scjohns pushed a commit that referenced this pull request Apr 24, 2023
@BolajiOlajide @LawnGnome
batches: add SRC_HEADERS for passing multiple custom headers (#796)
6b5b9c6 
Co-authored-by: Adam Harvey <adam@adamharvey.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LawnGnome LawnGnome LawnGnome approved these changes

@Piszmog Piszmog Piszmog approved these changes

Assignees

@BolajiOlajide BolajiOlajide

Labels
team/code-search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace _ with - in custom headers
3 participants
@BolajiOlajide @LawnGnome @Piszmog