Add support for SCIP + renaming. #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efritz
reviewed
May 13, 2022
efritz
approved these changes
May 13, 2022
This kind of nonsense is why I hate global variables. Yuck.
Fix file is not goimports-ed.
Avoid Unix path separator in test.
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Document why the flags are being modified after-the-fact. This kind of nonsense is why I hate global variables. Yuck. * Add support for SCIP uploads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the name
index.scipas the default. I've also renameda bunch of stuff which was referring to LSIF Typed.
Marking as draft for now since the code won't compile until
the SCIP repo is made public, and I also need to add tests.
Test plan
Updated existing tests + added new tests.