Remove CSRF tokens fetching code #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LawnGnome
approved these changes
Dec 20, 2021
There was a problem hiding this comment.
LGTM, with the caveats from our Slack thread that I know basically nothing about src validate. Could you add a changelog entry, please, since this appears to be a version interop concern that might affect end users as well as us?
Note to self: this should probably be migrated to api.Client at some point, rather than having a whole separate client implementation just for validate.
jhchabran
added a commit
to sourcegraph/deploy-sourcegraph
that referenced
this pull request
Dec 20, 2021
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Remove CSRF tokens fetching code * Remove unused func * Update CHANGELOG. Co-authored-by: Adam Harvey <adam@adamharvey.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to this problem reported on Slack.
Due to https://github.com/sourcegraph/sourcegraph/pull/28572, the CSRF headers were removed and due to a bug in the error checking code, triggers a panic.