codeintel: add an --associated-index-id flag for autoindexer usage #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
efritz
approved these changes
Jan 18, 2021
cmd/src/lsif_upload.go
Outdated
| @@ -71,6 +72,7 @@ Examples: | |||
| flags.ignoreUploadFailures = flagSet.Bool("ignore-upload-failure", false, `Exit with status code zero on upload failure.`) | |||
| flags.uploadRoute = flagSet.String("upload-route", "/.api/lsif/upload", "The path of the upload route.") | |||
There was a problem hiding this comment.
Should we add 'internal use only' here too?
There was a problem hiding this comment.
Sure, if someone's changed this in a forked Sourcegraph instance they'll happily ignore that instruction.
efritz
reviewed
Jan 18, 2021
| @@ -70,7 +70,7 @@ Examples: | |||
| flags.noProgress = flagSet.Bool("no-progress", false, `Do not display a progress bar.`) | |||
| flags.maxPayloadSizeMb = flagSet.Int("max-payload-size", 100, `The maximum upload size (in megabytes). Indexes exceeding this limit will be uploaded over multiple HTTP requests.`) | |||
| flags.ignoreUploadFailures = flagSet.Bool("ignore-upload-failure", false, `Exit with status code zero on upload failure.`) | |||
| flags.uploadRoute = flagSet.String("upload-route", "/.api/lsif/upload", "The path of the upload route.") | |||
| flags.uploadRoute = flagSet.String("upload-route", "/.api/lsif/upload", "The path of the upload route. For internal use only.") | |||
efritz
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to wait for the codeintelutils update before this works.