Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use api.Client for http request in src version #411

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Conversation

eseliger
Copy link
Member

This fixes us not using any authentication in the src version command, because the api.Client adds the Authorization header to the request automatically

This fixes us not using any authentication in the src version command, because the api.Client adds the Authorization header to the request automatically
@eseliger eseliger added bug Something isn't working team/code-search labels Dec 16, 2020
@eseliger eseliger requested review from emidoots and a team December 16, 2020 21:22
Copy link
Contributor

@LawnGnome LawnGnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably worth a changelog entry, but otherwise this LGTM.

@eseliger eseliger merged commit d12fcd4 into main Dec 16, 2020
@eseliger eseliger deleted the es/use-auth-version branch December 16, 2020 21:30
Copy link
Contributor

@chrispine chrispine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick turnaround!

scjohns pushed a commit that referenced this pull request Apr 24, 2023
This fixes us not using any authentication in the src version command, because the api.Client adds the Authorization header to the request automatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working team/code-search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants