Query and use the repository.branch when defined in spec #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba6712c to
e0fdeda
Compare
33 tasks
eseliger
approved these changes
Nov 23, 2020
|
Thanks for tackling this! |
LawnGnome
approved these changes
Nov 24, 2020
| type Branch struct { | ||
| Name string | ||
| Target struct{ OID string } | ||
| Target Target |
|
I hit Control-Enter too early, but the one thing that we do need is a changelog! |
993733d to
e74598e
Compare
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Query and use the repository.branch when defined in spec * Remove debug pritning * Query specific commit and not query branches * Merge two repository queries * Fix critical indentation error (and unused type) * Fix wrong query * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://github.com/sourcegraph/sourcegraph/issues/15070 by changing the evaluation of the
on.repositoryfield in the campaign spec to actually query for and use thebranchattribute.It queries the GraphQL API for a commit that matches the exact rev and returns an error if no commit was found.
If the campaign spec uses
repositoriesMatchingQueryandrepository, like thisthen the second branch,
thorstens-test-branch, is checked out and used as the base branch for the changeset.What we don't support yet is using a revspec in the search query, like
repo:github.com/sourcegraph/automation-testing@thorstens-test-branch foobar, and using that to check out the branch. We can tackle that in a separate ticket/PR.For now, this fixes the original problem and allows users to run the steps for a specified subset of repositories in specific branches.
(Side note: the search results in the template variable
${{ repository.search_result_paths }}are populated by the query, even though they might not match any results in the second branch — that's undefined behaviour for now, but I want to document it in the docs.)