Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: improve Windows console handling #274

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

LawnGnome
Copy link
Contributor

The new output code is pretty nifty in Windows Terminal, but users still using the legacy console with cmd.exe or PowerShell are going to get pretty ugly output, since the escape codes aren't handled by default. This adds support for enabling virtual terminal processing, which makes things pretty. (Well, prettier, anyway. Note also #273.)

The new output code is pretty nifty in Windows Terminal, but users still using
the legacy console with cmd.exe or PowerShell are going to get pretty ugly
output, since the escape codes aren't handled by default. This adds support for
enabling virtual terminal processing, which makes things pretty. (Well,
prettier, anyway. Note also #273.)
Copy link
Contributor

@mrnugget mrnugget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Going above and beyond here — better Windows console support 😄

@LawnGnome LawnGnome merged commit c5a7ae0 into master Aug 21, 2020
scjohns pushed a commit that referenced this pull request Apr 24, 2023
The new output code is pretty nifty in Windows Terminal, but users still using
the legacy console with cmd.exe or PowerShell are going to get pretty ugly
output, since the escape codes aren't handled by default. This adds support for
enabling virtual terminal processing, which makes things pretty. (Well,
prettier, anyway. Note also #273.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants