feature/security: Implement image signature verification #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
golangci-lint setup seems to be failing in CI, but I've run locally and no issues flagged in these changes. |
willdollman
added a commit
to sourcegraph/docs
that referenced
this pull request
Feb 5, 2025
Add documentation for verifying container signatures using `src signature verify`, as introduced in sourcegraph/src-cli#1143. Also update SBOM documentation to align with the signature verification docs. - https://sourcegraph-docs-git-will-container-6ad7d6-sourcegraph-f8c71130.vercel.app/docs/cli/how-tos/verify_container_signatures - https://sourcegraph-docs-git-will-container-6ad7d6-sourcegraph-f8c71130.vercel.app/docs/cli/how-tos/fetch_sboms ## Pull Request approval You will need to get your PR approved by at least one member of the Sourcegraph team. For reviews of docs formatting, styles, and component usage, please tag the docs team via the #docs Slack channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement verification of container signatures for release images. This allows customers to easily verify the signatures we started publishing in SEC-2445.
The implementation shares several helper functions with the
src sbom fetchcommand, as both fetch information about releases, talk to our container registries, and usecosignbehind the scenes.The verification process is:
cosign verifywith our public keyDigests can then be used or checked against our deployment configs by customers. Customers could also use the sigstore admission controller on their cluster to automate this, but allowing signature verification via
src-cliis convenient and a small code change.Signature verification of a subset of images:
Test plan