This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Fix search bar too tall in plaintext mode #9960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9960 +/- ##
=======================================
Coverage 42.77% 42.77%
=======================================
Files 1347 1347
Lines 73934 73934
Branches 6625 6625
=======================================
Hits 31623 31623
Misses 39451 39451
Partials 2860 2860
|
lguychard
approved these changes
Apr 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the smart search field being too tall: https://sourcegraph.slack.com/archives/CMT39K56Z/p1587132156164100.
Was introduced in https://github.com/sourcegraph/sourcegraph/commit/4f7910861b709a7ee0ab671a1b0511f1a38ceff7. We didn't need the vertical padding to actually fix the issue.
cc @uwedeportivo this needs to be cherry-picked on to 3.15 as it's a regression.