This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
WIP: add hasbeenactive #43370
Closed
WIP: add hasbeenactive #43370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnugget
commented
Oct 24, 2022
…ing of includeNeverActive I'd like the default behavior to be -- without this filter never active users are not returned by the inactiveSince query left off working on unit tests -- incomplete state
efritz
suggested changes
Nov 4, 2022
internal/database/users.go
Outdated
Comment on lines
811
to
812
| // NeverActive filters out users that have never had an eventlog entry if true. | ||
| NeverActive bool |
There was a problem hiding this comment.
- Rename
- Redocument to match graphql layer semantics
…ter -- TODO: create new unit Tests for both TestUsers_InactiveSince & TestUsers_IncludeNeverActive
mrnugget
commented
Nov 8, 2022
cmd/frontend/graphqlbackend/users.go
Outdated
| @@ -34,6 +35,9 @@ func (r *schemaResolver) Users(args *usersArgs) *userConnectionResolver { | |||
| if args.InactiveSince != nil { | |||
| opt.InactiveSince = args.InactiveSince.Time | |||
| } | |||
| if args.IncludeNeverActive != nil { | |||
There was a problem hiding this comment.
I think this should also be nested under if args.InactiveSince != nil {
|
After exploring this a bit more I will need to review the logic and rename some variables that are named never active -- this is in light of the fact that users may have I still think having a filter here is going to come in handy though, in |
…e really indicates
|
Closing in light of: sourcegraph/src-cli#901 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add a sorting flag for returning users that have a null value for
lastActiveTimeor not. This user state may be caused by a user having never been active on the Sourcegraph instance, or having not been active for 93 days (this is the length of time entries in theevent_logstable are persisted in the database)Test plan
Unit Tests